refactor(transformer/jsx): do not take None when extracting key prop#9228
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 19, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-cleanup
CodSpeed Performance ReportMerging #9228 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
02-19-refactor_transformer_jsx_do_not_take_none_when_extracting_key_prop
branch
from
bf88ea7 to
532498e
Compare
Member
Author
Oh man! Not this nonsense again... this benchmark result is clearly erroneous noise. This PR doesn't touch Semantic! |
Dunqing
approved these changes
Feb 19, 2025
Member
Merge activity
|
…rop (#9228) Tiny refactor to JSX transform. There's no point setting `key_prop = None`, so skip this branch unless the `key` attribute has a value (it always should). We can also remove the `.take()` call.
graphite-app
bot
force-pushed
the
02-19-refactor_transformer_jsx_refactor_and_document_has_proto_
branch
from
7a4b939 to
45e0876
Compare
graphite-app
bot
force-pushed
the
02-19-refactor_transformer_jsx_do_not_take_none_when_extracting_key_prop
branch
from
532498e to
7c10ae5
Compare
Base automatically changed from
02-19-refactor_transformer_jsx_refactor_and_document_has_proto_
to
main
February 19, 2025 14:53
graphite-app
bot
deleted the
02-19-refactor_transformer_jsx_do_not_take_none_when_extracting_key_prop
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny refactor to JSX transform. There's no point setting
key_prop = None, so skip this branch unless thekeyattribute has a value (it always should).We can also remove the
.take()call.