refactor(transformer/jsx): avoid span() method calls#9226
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 19, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-cleanup
CodSpeed Performance ReportMerging #9226 will not alter performanceComparing Summary
|
Dunqing
approved these changes
Feb 19, 2025
Contributor
Merge activity
|
Tiny refactor of JSX transform. We already matched on `name: JSXAttributeName` and have a reference to the `JSXIdentifier` it contains, so just get `span` from it directly, rather than calling `name.span()` which branches on the type of `name` again.
graphite-app
bot
force-pushed
the
02-19-refactor_transformer_jsx_avoid_span_method_calls
branch
from
4251524 to
8fe8937
Compare
graphite-app
bot
deleted the
02-19-refactor_transformer_jsx_avoid_span_method_calls
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny refactor of JSX transform.
We already matched on
name: JSXAttributeNameand have a reference to theJSXIdentifierit contains, so just getspanfrom it directly, rather than callingname.span()which branches on the type ofnameagain.