refactor(span): implement Serialize manually for Atom#9196
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 18, 2025
Merged
Conversation
github-actions
bot
added
the
C-cleanup
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #9196 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
02-18-refactor_ast_estree_simplify_serializing_formalparameters_
branch
from
bace421 to
58fabd2
Compare
overlookmotel
force-pushed
the
02-18-refactor_span_implement_serialize_manually_for_atom_
branch
from
af2a0be to
2ecd03d
Compare
Member
Author
What the hell? Something is clearly wrong! |
Member
Author
I force pushed (without changing any code) and it's gone back to normal now. I guess must have been a temporary blip. I guess the fixture file for that benchmark was not downloaded, so it ran on an empty file - which obviously is very much faster. |
Boshen
changed the base branch from
02-18-refactor_ast_estree_simplify_serializing_formalparameters_
to
graphite-base/9196
Boshen
force-pushed
the
graphite-base/9196
branch
from
58fabd2 to
3236fe4
Compare
Boshen
force-pushed
the
02-18-refactor_span_implement_serialize_manually_for_atom_
branch
from
2ecd03d to
0cd2e29
Compare
Boshen
force-pushed
the
02-18-refactor_span_implement_serialize_manually_for_atom_
branch
from
0cd2e29 to
74e519b
Compare
overlookmotel
force-pushed
the
02-18-refactor_span_implement_serialize_manually_for_atom_
branch
from
74e519b to
b1877f4
Compare
Member
Author
Merge activity
|
The `Serialize` impl for `Atom` is trivial, so there's no need to use `#[derive(Serialize)]` on it - just implement it by hand. This is another step towards removing `serde-derive` from `oxc_span` and `oxc_ast`, which when complete will greatly improve compile times. Also shorten the code for `impl Serialize for CompactStr`. That change is pure style refactor.
graphite-app
bot
force-pushed
the
02-18-refactor_span_implement_serialize_manually_for_atom_
branch
from
b1877f4 to
be27164
Compare
graphite-app
bot
deleted the
02-18-refactor_span_implement_serialize_manually_for_atom_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Serializeimpl forAtomis trivial, so there's no need to use#[derive(Serialize)]on it - just implement it by hand.This is another step towards removing
serde-derivefromoxc_spanandoxc_ast, which when complete will greatly improve compile times.Also shorten the code for
impl Serialize for CompactStr. That change is pure style refactor.