refactor(ast/estree): simplify serializing FormalParameters#9195
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 18, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-ast
CodSpeed Performance ReportMerging #9195 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
02-18-refactor_ast_estree_simplify_serializing_formalparameters_
branch
from
bace421 to
58fabd2
Compare
Member
Merge activity
|
Simplify the custom `Serialize` impl for `FormalParameters`. This removes the last `#[derive(Serialize)]` in `oxc_ast` crate, which means we can turn off `serde`'s `derive` feature for this crate. Unfortunately, `oxc_ast` depends on `oxc_span`, and that crate still uses `#[derive(Deserialize)]`. Therefore `oxc_ast` still has a transitive dependency on `serde-derive`. But this is a step to removing it, which when we do will greatly improve compile times.
graphite-app
bot
force-pushed
the
02-18-refactor_ast_estree_simplify_serializing_formalparameters_
branch
from
58fabd2 to
3236fe4
Compare
graphite-app
bot
deleted the
02-18-refactor_ast_estree_simplify_serializing_formalparameters_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the custom
Serializeimpl forFormalParameters.This removes the last
#[derive(Serialize)]inoxc_astcrate, which means we can turn offserde'sderivefeature for this crate.Unfortunately,
oxc_astdepends onoxc_span, and that crate still uses#[derive(Deserialize)]. Thereforeoxc_aststill has a transitive dependency onserde-derive. But this is a step to removing it, which when we do will greatly improve compile times.