Skip to content

fix(transformer/class-properties): do not insert an empty iterator to insert_many_before#9157

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-16-fix_transformer_statement-injector_skip_empty_iterator
Feb 18, 2025
Merged

fix(transformer/class-properties): do not insert an empty iterator to insert_many_before#9157
graphite-app[bot] merged 1 commit intomainfrom
02-16-fix_transformer_statement-injector_skip_empty_iterator

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Feb 16, 2025

Insert an empty iterator which will cause panic after #9063

Copy link
Member Author

Dunqing commented Feb 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing marked this pull request as ready for review February 16, 2025 07:21
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 16, 2025

CodSpeed Performance Report

Merging #9157 will not alter performance

Comparing 02-16-fix_transformer_statement-injector_skip_empty_iterator (c2101ad) with main (611b029)

Summary

✅ 33 untouched benchmarks

@Dunqing Dunqing force-pushed the 02-16-fix_transformer_statement-injector_skip_empty_iterator branch from 52bbfc2 to a851799 Compare February 17, 2025 08:20
@Dunqing Dunqing changed the title fix(transformer/statement-injector): skip empty iterator fix(transformer/class-properties): do not insert an empty iterator to insert_many_before Feb 17, 2025
Copy link
Member

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution!

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 18, 2025
Copy link
Member

overlookmotel commented Feb 18, 2025

Merge activity

  • Feb 18, 4:42 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 18, 4:42 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 18, 4:47 PM EST: A user merged this pull request with the Graphite merge queue.

… `insert_many_before` (#9157)

Insert an empty iterator which will cause panic after #9063
@graphite-app graphite-app bot force-pushed the 02-16-fix_transformer_statement-injector_skip_empty_iterator branch from a851799 to c2101ad Compare February 18, 2025 21:43
@graphite-app graphite-app bot merged commit c2101ad into main Feb 18, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 02-16-fix_transformer_statement-injector_skip_empty_iterator branch February 18, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants