feat(transformer/statement-injector): add an assertion to check if it still contains statements that don't inject#9063
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 18, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-transformer
CodSpeed Performance ReportMerging #9063 will not alter performanceComparing Summary
|
overlookmotel
approved these changes
Feb 15, 2025
Member
overlookmotel
left a comment
overlookmotel
left a comment
There was a problem hiding this comment.
This is a really good idea. You can ignore my nit about naming if you can't be bothered!
Dunqing
force-pushed
the
02-12-fix_transformer_decorator_decoration_disappear_due_to_incorrect_statement_address
branch
from
27b2fe4 to
0abf0d8
Compare
Dunqing
force-pushed
the
02-12-feat_transformer_statement-injector_add_an_assertion_to_check_if_it_still_contains_statements_that_don_t_inject
branch
from
c35f52b to
06b6052
Compare
Dunqing
changed the base branch from
02-12-fix_transformer_decorator_decoration_disappear_due_to_incorrect_statement_address
to
graphite-base/9063
Dunqing
force-pushed
the
02-12-feat_transformer_statement-injector_add_an_assertion_to_check_if_it_still_contains_statements_that_don_t_inject
branch
from
06b6052 to
61d2090
Compare
Dunqing
force-pushed
the
graphite-base/9063
branch
from
0abf0d8 to
52bbfc2
Compare
Dunqing
changed the base branch from
graphite-base/9063
to
02-16-fix_transformer_statement-injector_skip_empty_iterator
Dunqing
force-pushed
the
02-12-feat_transformer_statement-injector_add_an_assertion_to_check_if_it_still_contains_statements_that_don_t_inject
branch
2 times, most recently
from
3896b18 to
29d72ae
Compare
Dunqing
force-pushed
the
02-16-fix_transformer_statement-injector_skip_empty_iterator
branch
from
52bbfc2 to
a851799
Compare
overlookmotel
approved these changes
Feb 18, 2025
overlookmotel
changed the base branch from
02-16-fix_transformer_statement-injector_skip_empty_iterator
to
graphite-base/9063
overlookmotel
force-pushed
the
graphite-base/9063
branch
from
a851799 to
c2101ad
Compare
overlookmotel
force-pushed
the
02-12-feat_transformer_statement-injector_add_an_assertion_to_check_if_it_still_contains_statements_that_don_t_inject
branch
from
29d72ae to
f5e73e0
Compare
Member
Merge activity
|
overlookmotel
force-pushed
the
02-12-feat_transformer_statement-injector_add_an_assertion_to_check_if_it_still_contains_statements_that_don_t_inject
branch
from
f5e73e0 to
d7e3555
Compare
… still contains statements that don't inject (#9063) When there are still statements that aren't inserted after the visitor ends, it means statements inserted with an incorrect address or outdated address (e.g., the original statement has mutated to a new statement). This PR adds an assertion to expose this potential bug as soon as possible on the development side.
graphite-app
bot
force-pushed
the
02-12-feat_transformer_statement-injector_add_an_assertion_to_check_if_it_still_contains_statements_that_don_t_inject
branch
from
d7e3555 to
3289721
Compare
graphite-app
bot
deleted the
02-12-feat_transformer_statement-injector_add_an_assertion_to_check_if_it_still_contains_statements_that_don_t_inject
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are still statements that aren't inserted after the visitor ends, it means statements inserted with an incorrect address or outdated address (e.g., the original statement has mutated to a new statement).
This PR adds an assertion to expose this potential bug as soon as possible on the development side.