Skip to content

refactor(minifier): move equality comparison to ConstantEvaluation#9009

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-10-refactor_minifier_move_equality_comparison_to_constantevaluation
Feb 10, 2025
Merged

refactor(minifier): move equality comparison to ConstantEvaluation#9009
graphite-app[bot] merged 1 commit intomainfrom
02-10-refactor_minifier_move_equality_comparison_to_constantevaluation

Conversation

@sapphi-red
Copy link
Member

No description provided.

Copy link
Member Author

sapphi-red commented Feb 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 10, 2025
@sapphi-red sapphi-red marked this pull request as ready for review February 10, 2025 13:02
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 10, 2025

CodSpeed Performance Report

Merging #9009 will not alter performance

Comparing 02-10-refactor_minifier_move_equality_comparison_to_constantevaluation (9b5d800) with main (b416334)

Summary

✅ 33 untouched benchmarks

@sapphi-red sapphi-red changed the base branch from 02-10-feat_minifier_fold_constants_if_the_folded_expression_is_shorter_than_the_original_one to graphite-base/9009 February 10, 2025 13:15
@sapphi-red sapphi-red force-pushed the 02-10-refactor_minifier_move_equality_comparison_to_constantevaluation branch from 8f8a3c9 to f6b09ea Compare February 10, 2025 13:25
@sapphi-red sapphi-red changed the base branch from graphite-base/9009 to main February 10, 2025 13:26
@sapphi-red sapphi-red force-pushed the 02-10-refactor_minifier_move_equality_comparison_to_constantevaluation branch from f6b09ea to 5e3a0b2 Compare February 10, 2025 13:28
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Feb 10, 2025
Copy link
Member

Boshen commented Feb 10, 2025

Merge activity

  • Feb 10, 8:37 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 10, 8:56 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 10, 9:19 AM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 02-10-refactor_minifier_move_equality_comparison_to_constantevaluation branch from 5e3a0b2 to 9b5d800 Compare February 10, 2025 14:09
@graphite-app graphite-app bot merged commit 9b5d800 into main Feb 10, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 02-10-refactor_minifier_move_equality_comparison_to_constantevaluation branch February 10, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants