feat(minifier): fold constants if the folded expression is shorter than the original one

[sapphi-red]

No description provided.

[sapphi-red]

• feat(minifier): remove useless string addition #9011
• refactor(minifier): remove duplicated typeof comparison to non-strict equality compression #9010
• refactor(minifier): move equality comparison to ConstantEvaluation #9009
• feat(minifier): fold constants if the folded expression is shorter than the original one #9008 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Boshen]

Can you move this out of the stack so I can merge the other PRs first? This PR is interesting ;-)

[codspeed-hq]

CodSpeed Performance Report

Merging #9008 will degrade performances by 87.02%

_{Comparing 02-10-feat_minifier_fold_constants_if_the_folded_expression_is_shorter_than_the_original_one (1857746) with main (81bed37)}

Summary

❌ 3 regressions
✅ 30 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	minifier[antd.js]	159.8 ms	1,230.9 ms	-87.02%
❌	minifier[react.development.js]	1.6 ms	9.9 ms	-83.65%
❌	minifier[typescript.js]	275.1 ms	1,326.2 ms	-79.26%

[Boshen]

I knew it!

Merging #9008 will degrade performances by 87.02%

[sapphi-red]

Because I'm not calling CodeGen::build in count_char_when_printing, self.regex.pattern.source_text(p.source_text) errors due to CodeGen::source_text being an empty string.

let mut cg = Codegen::new()
    .with_options(CodegenOptions { minify: true, ..CodegenOptions::default() });
cg.print_expression(expr);
cg.into_source_text().len()

[Boshen]

Let's reconsider this approach once we stabilize the minifier.