refactor(ast): add NULL value for serializing null types#8987
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 10, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #8987 will not alter performanceComparing Summary
|
camchenry
changed the title
NULL value for serializing null typesNULL value for serializing null types
github-actions
bot
added
the
C-cleanup
hi-ogawa
reviewed
Feb 10, 2025
Contributor
hi-ogawa
left a comment
hi-ogawa
left a comment
There was a problem hiding this comment.
Nice! There are two more value = () in crates/oxc_ast/src/ast/literal.rs. Can we change that too?
overlookmotel
changed the base branch from
02-08-fix_ast_add_missing_estree_props_for_arrowfunctionexpression_
to
graphite-base/8987
overlookmotel
force-pushed
the
02-09-reactor_ast_add_null_value_for_serializing_null_types
branch
from
71bf6f8 to
b45bf2c
Compare
overlookmotel
force-pushed
the
graphite-base/8987
branch
from
63409bc to
ec1d593
Compare
overlookmotel
force-pushed
the
02-09-reactor_ast_add_null_value_for_serializing_null_types
branch
from
b45bf2c to
a92f16a
Compare
Member
In the interests of merging this swiftly, I've pushed an extra commit to do that. |
overlookmotel
approved these changes
Feb 10, 2025
Member
Merge activity
|
from #8980 (comment), added a special value that just represents a unit type, which should always be serialized to `null`
graphite-app
bot
force-pushed
the
02-09-reactor_ast_add_null_value_for_serializing_null_types
branch
from
a877e45 to
0929320
Compare
graphite-app
bot
deleted the
02-09-reactor_ast_add_null_value_for_serializing_null_types
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from #8980 (comment), added a special value that just represents a unit type, which should always be serialized to
null