fix(ast): add missing estree props for ArrowFunctionExpression#8980
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 10, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-ast
CodSpeed Performance ReportMerging #8980 will not alter performanceComparing Summary
|
hi-ogawa
reviewed
Feb 9, 2025
camchenry
force-pushed
the
02-08-fix_ast_add_missing_estree_props_for_arrowfunctionexpression_
branch
from
7087caa to
63409bc
Compare
hi-ogawa
approved these changes
Feb 9, 2025
Member
Merge activity
|
overlookmotel
approved these changes
Feb 10, 2025
building on @overlookmotel and @hi-ogawa's fine work, I thought I would lend a hand at trying to add some missing estree props. this PR adds the `generator` property and `id` property for `ArrowFunctionExpression`. the `id` property requires serializing a constant `null` value, which seemed like it required some funky output in the serializer. would appreciate some suggestions on how to make this cleaner 🙏
graphite-app
bot
force-pushed
the
02-08-fix_ast_add_missing_estree_props_for_arrowfunctionexpression_
branch
from
63409bc to
ec1d593
Compare
graphite-app
bot
deleted the
02-08-fix_ast_add_missing_estree_props_for_arrowfunctionexpression_
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
from #8980 (comment), added a special value that just represents a unit type, which should always be serialized to `null`
overlookmotel
pushed a commit
that referenced
this pull request
Feb 10, 2025
…ression` (#8988) Part of #2854 Serialization of `ArrowFunctionExpression.body` requires knowing `ArrowFunctionExpression.expression: boolean`, so I generalized `ESTreeStructField::via` macro to cover this use case. This alone doesn't improve conformance since `ArrowFunctionExpression.generator/id` needs to be fixed first by #8980.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
building on @overlookmotel and @hi-ogawa's fine work, I thought I would lend a hand at trying to add some missing estree props.
this PR adds the
generatorproperty andidproperty forArrowFunctionExpression. theidproperty requires serializing a constantnullvalue, which seemed like it required some funky output in the serializer. would appreciate some suggestions on how to make this cleaner 🙏