fix(ast): include directives in body#8981
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 10, 2025
Merged
Conversation
This was referenced Feb 9, 2025
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-ast
CodSpeed Performance ReportMerging #8981 will improve performances by 3.4%Comparing Summary
Benchmarks breakdown
|
Boshen
force-pushed
the
fix-ast-CatchClause
branch
2 times, most recently
from
fdcbdad to
9911dcf
Compare
Boshen
force-pushed
the
fix-ast-append-to-non-optional
branch
from
b7dc9ac to
54d527a
Compare
overlookmotel
force-pushed
the
fix-ast-CatchClause
branch
from
9911dcf to
a0f1d6b
Compare
overlookmotel
force-pushed
the
fix-ast-append-to-non-optional
branch
from
4079f76 to
e8d5a7a
Compare
overlookmotel
changed the base branch from
fix-ast-CatchClause
to
graphite-base/8981
overlookmotel
force-pushed
the
graphite-base/8981
branch
from
a0f1d6b to
8eccdec
Compare
overlookmotel
force-pushed
the
fix-ast-append-to-non-optional
branch
from
e8d5a7a to
667b88a
Compare
overlookmotel
force-pushed
the
fix-ast-append-to-non-optional
branch
from
667b88a to
80e8c4a
Compare
hi-ogawa
force-pushed
the
fix-ast-append-to-non-optional
branch
from
7535ac8 to
9c63b69
Compare
overlookmotel
force-pushed
the
fix-ast-append-to-non-optional
branch
from
9c63b69 to
88fe429
Compare
overlookmotel
approved these changes
Feb 10, 2025
Member
Merge activity
|
Part of #2854 Related: #8972 (comment) I updated `append_to` macro to support concatenating two `Vec`. The logic is very similar so I reused it, but maybe it's better to introduce a new macro or maybe rename `append_to`?
graphite-app
bot
force-pushed
the
fix-ast-append-to-non-optional
branch
from
88fe429 to
7e6a537
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2854
Related: #8972 (comment)
I updated
append_tomacro to support concatenating twoVec. The logic is very similar so I reused it, but maybe it's better to introduce a new macro or maybe renameappend_to?