fix(ast): estree compat Function

[hi-ogawa]

Part of #2854

diff of estree_test262.snap

-Positive Passed: 6233/44293 (14.07%)
+Positive Passed: 13042/44293 (29.44%)

[hi-ogawa]

• fix(ast): include directives in body #8981
• fix(ast): estree compat CatchClause #8975
• fix(ast): estree compat Property #8974
• fix(ast): estree compat UnaryExpression #8973
• fix(ast): estree compat Function #8972 👈 (View in Graphite)
• test(ast): remove old ast snapshot tests #8976
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #8972 will not alter performance

_{Comparing fix-ast-estree-function (a2883b1) with main (f2d28f3)}

Summary

✅ 33 untouched benchmarks

[hi-ogawa]

both directives and statements should be in body, but append_to macro seems to break for non optional field. I'll look into updating macro for this case separately.

[overlookmotel]

Yes, extending #[estree(append_to = ...)] to cover appending Vecs too would be ideal. We could alternatively add #[estree(prepend_to = ...)], which would make more sense here. But I think for now we already have enough attributes - probably better to use append_to at least for now.

Let me know if you have trouble working out how to adapt the codegen. I think it mostly makes sense, but I wrote it, so of course it makes sense to me!

[overlookmotel]

Great!

Side note: I'm wondering in what circumstances the expression field is true?

Seems not to be true for function expressions (AST explorer). So when is it true? I guess we'll find out as we progress through the test cases...

[overlookmotel]

Merge activity

• Feb 9, 1:52 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Feb 9, 1:52 PM EST: A user added this pull request to the Graphite merge queue.
• Feb 9, 1:57 PM EST: A user merged this pull request with the Graphite merge queue.

[hi-ogawa]

Side note: I'm wondering in what circumstances the expression field is true?

I just looked into estree and this is probably for some ancient deprecated feature https://github.com/estree/estree/blob/2b48e56efc223ea477a45b5e034039934c5791fa/deprecated.md#functions

In https://bugzilla.mozilla.org/show_bug.cgi?id=1083458, I found a weird syntax like function(l) null for the first time 😮

[overlookmotel]

I just looked into estree and this is probably for some ancient deprecated feature https://github.com/estree/estree/blob/2b48e56efc223ea477a45b5e034039934c5791fa/deprecated.md#functions

In https://bugzilla.mozilla.org/show_bug.cgi?id=1083458, I found a weird syntax like function(l) null for the first time 😮

Ah ha! function(l) null - thank god this did not take off!