Skip to content

feat(ecmascript): ValueType::from for PrivateInExpression#8964

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-07-feat_ecmascript_valuetype_from_for_privateinexpression
Feb 8, 2025
Merged

feat(ecmascript): ValueType::from for PrivateInExpression#8964
graphite-app[bot] merged 1 commit intomainfrom
02-07-feat_ecmascript_valuetype_from_for_privateinexpression

Conversation

@sapphi-red
Copy link
Member

No description provided.

Copy link
Member Author

sapphi-red commented Feb 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red marked this pull request as ready for review February 7, 2025 13:40
@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Feb 7, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 7, 2025

CodSpeed Performance Report

Merging #8964 will create unknown performance changes

Comparing 02-07-feat_ecmascript_valuetype_from_for_privateinexpression (dd383c0) with 02-07-feat_ecmascript_valuetype_from_for_parenthesized_expressions (c3eef2f)

Summary

🆕 33 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 24.9 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 68.3 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 723.7 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 20.6 µs N/A
🆕 lexer[antd.js] N/A 22 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.5 ms N/A
🆕 lexer[checker.ts] N/A 13.2 ms N/A
🆕 lexer[pdf.mjs] N/A 3.6 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.6 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.8 s N/A
🆕 mangler[antd.js] N/A 16.2 ms N/A
🆕 mangler[react.development.js] N/A 299.1 µs N/A
🆕 mangler[typescript.js] N/A 39.9 ms N/A
🆕 minifier[antd.js] N/A 158.6 ms N/A
🆕 minifier[react.development.js] N/A 1.6 ms N/A
🆕 minifier[typescript.js] N/A 272.1 ms N/A
🆕 estree[checker.ts] N/A 204.7 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 87.4 µs N/A
🆕 parser[antd.js] N/A 106.9 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Boshen Boshen force-pushed the 02-07-feat_ecmascript_valuetype_from_for_parenthesized_expressions branch from a48d468 to d675e89 Compare February 7, 2025 14:51
@Boshen Boshen force-pushed the 02-07-feat_ecmascript_valuetype_from_for_privateinexpression branch from 1e3c7c4 to abb7a67 Compare February 7, 2025 14:52
@sapphi-red sapphi-red changed the base branch from 02-07-feat_ecmascript_valuetype_from_for_parenthesized_expressions to graphite-base/8964 February 7, 2025 16:30
@sapphi-red sapphi-red force-pushed the 02-07-feat_ecmascript_valuetype_from_for_privateinexpression branch from abb7a67 to 9e0ea42 Compare February 7, 2025 16:32
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Feb 7, 2025
Copy link
Member

Boshen commented Feb 7, 2025

Merge activity

  • Feb 7, 6:46 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 7, 6:46 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 7, 7:23 PM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 02-07-feat_ecmascript_valuetype_from_for_privateinexpression branch from 9e0ea42 to dd383c0 Compare February 7, 2025 23:59
@graphite-app graphite-app bot changed the base branch from graphite-base/8964 to 02-07-feat_ecmascript_valuetype_from_for_parenthesized_expressions February 8, 2025 00:00
Base automatically changed from 02-07-feat_ecmascript_valuetype_from_for_parenthesized_expressions to main February 8, 2025 00:19
@graphite-app graphite-app bot merged commit dd383c0 into main Feb 8, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 02-07-feat_ecmascript_valuetype_from_for_privateinexpression branch February 8, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants