Skip to content

test(ecmascript): add test for ValueType and update document#8951

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-07-test_ecmascript_add_test_for_valuetype_and_update_document
Feb 7, 2025
Merged

test(ecmascript): add test for ValueType and update document#8951
graphite-app[bot] merged 1 commit intomainfrom
02-07-test_ecmascript_add_test_for_valuetype_and_update_document

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Feb 7, 2025

Wrote some tests for ValueType::from.

@github-actions github-actions bot added A-minifier Area - Minifier C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Feb 7, 2025
Copy link
Member Author

sapphi-red commented Feb 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red marked this pull request as ready for review February 7, 2025 09:21
@sapphi-red sapphi-red force-pushed the 02-07-test_ecmascript_add_test_for_valuetype_and_update_document branch from dd67082 to afdcd7f Compare February 7, 2025 09:23
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 7, 2025

CodSpeed Performance Report

Merging #8951 will not alter performance

Comparing 02-07-test_ecmascript_add_test_for_valuetype_and_update_document (cc7bb9c) with main (b5a7785)

Summary

✅ 33 untouched benchmarks

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 7, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 02-07-test_ecmascript_add_test_for_valuetype_and_update_document branch from afdcd7f to cc7bb9c Compare February 7, 2025 14:16
@graphite-app graphite-app bot merged commit cc7bb9c into main Feb 7, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 02-07-test_ecmascript_add_test_for_valuetype_and_update_document branch February 7, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant