Skip to content

fix(oxc_transformer): avoid const unwrap in base64 length calc #8914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
overlookmotel merged 2 commits into from
Feb 6, 2025
Merged

fix(oxc_transformer): avoid const unwrap in base64 length calc #8914

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc1e4ca
fix(oxc_transformer): avoid const unwrap in base64 length calc
CoderSerio Feb 5, 2025
dc1a153
Merge branch 'main' into main
CoderSerio Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion crates/oxc_transformer/src/jsx/refresh.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,13 @@ impl<'a> ReactRefresh<'a, '_> {
// We also need it for www that has transforms like cx()
// that don't understand if something is part of a string.
const SHA1_HASH_LEN: usize = 20;
const ENCODED_LEN: usize = base64_encoded_len(SHA1_HASH_LEN, true).unwrap();
const ENCODED_LEN: usize = {
let len = base64_encoded_len(SHA1_HASH_LEN, true);
match len {
Some(l) => l,
None => panic!("Invalid base64 length"),
}
};

let mut hasher = Sha1::new();
hasher.update(&key);
Expand Down