Skip to content

fix(oxc_transformer): avoid const unwrap in base64 length calc#8914

Merged
overlookmotel merged 2 commits intooxc-project:mainfrom
CoderSerio:main
Feb 6, 2025
Merged

fix(oxc_transformer): avoid const unwrap in base64 length calc#8914
overlookmotel merged 2 commits intooxc-project:mainfrom
CoderSerio:main

Conversation

@CoderSerio
Copy link
Contributor

fix #8913

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 5, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels Feb 5, 2025
@overlookmotel
Copy link
Member

Please see #8913 (comment). I'm not sure if this is required or not.

@Boshen Boshen marked this pull request as draft February 6, 2025 06:18
@Boshen Boshen marked this pull request as ready for review February 6, 2025 15:10
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #8914 will not alter performance

Comparing CoderSerio:main (dc1a153) with main (0df939c)

Summary

✅ 33 untouched benchmarks

@overlookmotel overlookmotel merged commit 1b89e75 into oxc-project:main Feb 6, 2025
26 checks passed
@overlookmotel
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compilation Error in oxc_transformer v0.48.2 on Rust

2 participants