feat(ast_tools): generate list of helper attributes in oxc_ast_macros crate#8852
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 3, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-ast-tools
CodSpeed Performance ReportMerging #8852 will not alter performanceComparing Summary
|
Contributor
Merge activity
|
…s` crate (#8852) Custom attributes used by generators (e.g. `#[visit]`) need to be added to the dummy `Ast` derive macro in `oxc_ast_macros`. Do this automatically, rather than requiring the person writing the generator to remember to do it.
graphite-app
bot
force-pushed
the
02-03-feat_ast_tools_do_not_overwrite_files_if_no_changes
branch
from
6b67d0b to
7b31849
Compare
graphite-app
bot
force-pushed
the
02-03-feat_ast_tools_generate_list_of_helper_attributes_in_oxc_ast_macros_crate
branch
from
fef0f46 to
e693ff3
Compare
Base automatically changed from
02-03-feat_ast_tools_do_not_overwrite_files_if_no_changes
to
main
February 3, 2025 13:17
graphite-app
bot
deleted the
02-03-feat_ast_tools_generate_list_of_helper_attributes_in_oxc_ast_macros_crate
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom attributes used by generators (e.g.
#[visit]) need to be added to the dummyAstderive macro inoxc_ast_macros. Do this automatically, rather than requiring the person writing the generator to remember to do it.