Skip to content

feat(ast_tools): do not overwrite files if no changes#8851

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-03-feat_ast_tools_do_not_overwrite_files_if_no_changes
Feb 3, 2025
Merged

feat(ast_tools): do not overwrite files if no changes#8851
graphite-app[bot] merged 1 commit intomainfrom
02-03-feat_ast_tools_do_not_overwrite_files_if_no_changes

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 3, 2025

If files do not need to change from what's already on disk, don't overwrite them. This avoids clippy etc reloading the files.

Copy link
Member Author

overlookmotel commented Feb 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast-tools Area - AST tools C-enhancement Category - New feature or request labels Feb 3, 2025
@overlookmotel overlookmotel marked this pull request as ready for review February 3, 2025 10:07
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 3, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 3, 2025

Merge activity

If files do not need to change from what's already on disk, don't overwrite them. This avoids clippy etc reloading the files.
@graphite-app graphite-app bot force-pushed the 02-03-refactor_ast_tools_shorten_code_for_reading_file branch from c58710e to e860944 Compare February 3, 2025 13:07
@graphite-app graphite-app bot force-pushed the 02-03-feat_ast_tools_do_not_overwrite_files_if_no_changes branch from 6b67d0b to 7b31849 Compare February 3, 2025 13:08
Base automatically changed from 02-03-refactor_ast_tools_shorten_code_for_reading_file to main February 3, 2025 13:12
@graphite-app graphite-app bot merged commit 7b31849 into main Feb 3, 2025
16 checks passed
@graphite-app graphite-app bot deleted the 02-03-feat_ast_tools_do_not_overwrite_files_if_no_changes branch February 3, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant