Skip to content

refactor(ast): comments for enums with no AstKind in generated code for Visit trait #8796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 31, 2025
Merged

refactor(ast): comments for enums with no AstKind in generated code for Visit trait #8796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions crates/oxc_ast/src/generated/visit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1406,6 +1406,7 @@ pub mod walk {
}

pub fn walk_statement<'a, V: Visit<'a>>(visitor: &mut V, it: &Statement<'a>) {
// No `AstKind` for this type
match it {
Statement::BlockStatement(it) => visitor.visit_block_statement(it),
Statement::BreakStatement(it) => visitor.visit_break_statement(it),
Expand Down Expand Up @@ -1492,6 +1493,7 @@ pub mod walk {
}

pub fn walk_expression<'a, V: Visit<'a>>(visitor: &mut V, it: &Expression<'a>) {
// No `AstKind` for this type
match it {
Expression::BooleanLiteral(it) => visitor.visit_boolean_literal(it),
Expression::NullLiteral(it) => visitor.visit_null_literal(it),
Expand Down Expand Up @@ -1787,6 +1789,7 @@ pub mod walk {
}

pub fn walk_ts_type<'a, V: Visit<'a>>(visitor: &mut V, it: &TSType<'a>) {
// No `AstKind` for this type
match it {
TSType::TSAnyKeyword(it) => visitor.visit_ts_any_keyword(it),
TSType::TSBigIntKeyword(it) => visitor.visit_ts_big_int_keyword(it),
Expand Down Expand Up @@ -2027,6 +2030,7 @@ pub mod walk {
visitor: &mut V,
it: &BindingPatternKind<'a>,
) {
// No `AstKind` for this type
match it {
BindingPatternKind::BindingIdentifier(it) => visitor.visit_binding_identifier(it),
BindingPatternKind::ObjectPattern(it) => visitor.visit_object_pattern(it),
Expand Down Expand Up @@ -2229,6 +2233,7 @@ pub mod walk {
visitor: &mut V,
it: &TSImportAttributeName<'a>,
) {
// No `AstKind` for this type
match it {
TSImportAttributeName::Identifier(it) => visitor.visit_identifier_name(it),
TSImportAttributeName::StringLiteral(it) => visitor.visit_string_literal(it),
Expand Down Expand Up @@ -2298,6 +2303,7 @@ pub mod walk {
}

pub fn walk_ts_literal<'a, V: Visit<'a>>(visitor: &mut V, it: &TSLiteral<'a>) {
// No `AstKind` for this type
match it {
TSLiteral::BooleanLiteral(it) => visitor.visit_boolean_literal(it),
TSLiteral::NullLiteral(it) => visitor.visit_null_literal(it),
Expand Down Expand Up @@ -2351,6 +2357,7 @@ pub mod walk {

#[inline]
pub fn walk_ts_tuple_element<'a, V: Visit<'a>>(visitor: &mut V, it: &TSTupleElement<'a>) {
// No `AstKind` for this type
match it {
TSTupleElement::TSOptionalType(it) => visitor.visit_ts_optional_type(it),
TSTupleElement::TSRestType(it) => visitor.visit_ts_rest_type(it),
Expand Down Expand Up @@ -2428,6 +2435,7 @@ pub mod walk {

#[inline]
pub fn walk_ts_signature<'a, V: Visit<'a>>(visitor: &mut V, it: &TSSignature<'a>) {
// No `AstKind` for this type
match it {
TSSignature::TSIndexSignature(it) => visitor.visit_ts_index_signature(it),
TSSignature::TSPropertySignature(it) => visitor.visit_ts_property_signature(it),
Expand Down Expand Up @@ -2565,6 +2573,7 @@ pub mod walk {
visitor: &mut V,
it: &TSTypePredicateName<'a>,
) {
// No `AstKind` for this type
match it {
TSTypePredicateName::Identifier(it) => visitor.visit_identifier_name(it),
TSTypePredicateName::This(it) => visitor.visit_ts_this_type(it),
Expand All @@ -2588,6 +2597,7 @@ pub mod walk {
visitor: &mut V,
it: &TSTypeQueryExprName<'a>,
) {
// No `AstKind` for this type
match it {
TSTypeQueryExprName::TSImportType(it) => visitor.visit_ts_import_type(it),
match_ts_type_name!(TSTypeQueryExprName) => {
Expand Down Expand Up @@ -2873,6 +2883,7 @@ pub mod walk {
visitor: &mut V,
it: &AssignmentTargetMaybeDefault<'a>,
) {
// No `AstKind` for this type
match it {
AssignmentTargetMaybeDefault::AssignmentTargetWithDefault(it) => {
visitor.visit_assignment_target_with_default(it)
Expand Down Expand Up @@ -2936,6 +2947,7 @@ pub mod walk {
visitor: &mut V,
it: &AssignmentTargetProperty<'a>,
) {
// No `AstKind` for this type
match it {
AssignmentTargetProperty::AssignmentTargetPropertyIdentifier(it) => {
visitor.visit_assignment_target_property_identifier(it)
Expand Down Expand Up @@ -3031,6 +3043,7 @@ pub mod walk {

#[inline]
pub fn walk_chain_element<'a, V: Visit<'a>>(visitor: &mut V, it: &ChainElement<'a>) {
// No `AstKind` for this type
match it {
ChainElement::CallExpression(it) => visitor.visit_call_expression(it),
ChainElement::TSNonNullExpression(it) => visitor.visit_ts_non_null_expression(it),
Expand Down Expand Up @@ -3106,6 +3119,7 @@ pub mod walk {

#[inline]
pub fn walk_class_element<'a, V: Visit<'a>>(visitor: &mut V, it: &ClassElement<'a>) {
// No `AstKind` for this type
match it {
ClassElement::StaticBlock(it) => visitor.visit_static_block(it),
ClassElement::MethodDefinition(it) => visitor.visit_method_definition(it),
Expand Down Expand Up @@ -3286,6 +3300,7 @@ pub mod walk {
visitor: &mut V,
it: &ObjectPropertyKind<'a>,
) {
// No `AstKind` for this type
match it {
ObjectPropertyKind::ObjectProperty(it) => visitor.visit_object_property(it),
ObjectPropertyKind::SpreadProperty(it) => visitor.visit_spread_element(it),
Expand Down Expand Up @@ -3506,6 +3521,7 @@ pub mod walk {

#[inline]
pub fn walk_jsx_attribute_name<'a, V: Visit<'a>>(visitor: &mut V, it: &JSXAttributeName<'a>) {
// No `AstKind` for this type
match it {
JSXAttributeName::Identifier(it) => visitor.visit_jsx_identifier(it),
JSXAttributeName::NamespacedName(it) => visitor.visit_jsx_namespaced_name(it),
Expand All @@ -3514,6 +3530,7 @@ pub mod walk {

#[inline]
pub fn walk_jsx_attribute_value<'a, V: Visit<'a>>(visitor: &mut V, it: &JSXAttributeValue<'a>) {
// No `AstKind` for this type
match it {
JSXAttributeValue::StringLiteral(it) => visitor.visit_string_literal(it),
JSXAttributeValue::ExpressionContainer(it) => {
Expand All @@ -3538,6 +3555,7 @@ pub mod walk {

#[inline]
pub fn walk_jsx_expression<'a, V: Visit<'a>>(visitor: &mut V, it: &JSXExpression<'a>) {
// No `AstKind` for this type
match it {
JSXExpression::EmptyExpression(it) => visitor.visit_jsx_empty_expression(it),
match_expression!(JSXExpression) => visitor.visit_expression(it.to_expression()),
Expand Down Expand Up @@ -3568,6 +3586,7 @@ pub mod walk {

#[inline]
pub fn walk_jsx_child<'a, V: Visit<'a>>(visitor: &mut V, it: &JSXChild<'a>) {
// No `AstKind` for this type
match it {
JSXChild::Text(it) => visitor.visit_jsx_text(it),
JSXChild::Element(it) => visitor.visit_jsx_element(it),
Expand Down Expand Up @@ -3648,6 +3667,7 @@ pub mod walk {

#[inline]
pub fn walk_for_statement_left<'a, V: Visit<'a>>(visitor: &mut V, it: &ForStatementLeft<'a>) {
// No `AstKind` for this type
match it {
ForStatementLeft::VariableDeclaration(it) => visitor.visit_variable_declaration(it),
match_assignment_target!(ForStatementLeft) => {
Expand Down Expand Up @@ -3870,6 +3890,7 @@ pub mod walk {
}

pub fn walk_declaration<'a, V: Visit<'a>>(visitor: &mut V, it: &Declaration<'a>) {
// No `AstKind` for this type
match it {
Declaration::VariableDeclaration(it) => visitor.visit_variable_declaration(it),
Declaration::FunctionDeclaration(it) => {
Expand Down Expand Up @@ -3991,6 +4012,7 @@ pub mod walk {

#[inline]
pub fn walk_ts_enum_member_name<'a, V: Visit<'a>>(visitor: &mut V, it: &TSEnumMemberName<'a>) {
// No `AstKind` for this type
match it {
TSEnumMemberName::Identifier(it) => visitor.visit_identifier_name(it),
TSEnumMemberName::String(it) => visitor.visit_string_literal(it),
Expand Down Expand Up @@ -4028,6 +4050,7 @@ pub mod walk {
visitor: &mut V,
it: &TSModuleDeclarationName<'a>,
) {
// No `AstKind` for this type
match it {
TSModuleDeclarationName::Identifier(it) => visitor.visit_binding_identifier(it),
TSModuleDeclarationName::StringLiteral(it) => visitor.visit_string_literal(it),
Expand All @@ -4039,6 +4062,7 @@ pub mod walk {
visitor: &mut V,
it: &TSModuleDeclarationBody<'a>,
) {
// No `AstKind` for this type
match it {
TSModuleDeclarationBody::TSModuleDeclaration(it) => {
visitor.visit_ts_module_declaration(it)
Expand Down Expand Up @@ -4147,6 +4171,7 @@ pub mod walk {
visitor: &mut V,
it: &ImportDeclarationSpecifier<'a>,
) {
// No `AstKind` for this type
match it {
ImportDeclarationSpecifier::ImportSpecifier(it) => visitor.visit_import_specifier(it),
ImportDeclarationSpecifier::ImportDefaultSpecifier(it) => {
Expand All @@ -4170,6 +4195,7 @@ pub mod walk {

#[inline]
pub fn walk_module_export_name<'a, V: Visit<'a>>(visitor: &mut V, it: &ModuleExportName<'a>) {
// No `AstKind` for this type
match it {
ModuleExportName::IdentifierName(it) => visitor.visit_identifier_name(it),
ModuleExportName::IdentifierReference(it) => visitor.visit_identifier_reference(it),
Expand Down Expand Up @@ -4232,6 +4258,7 @@ pub mod walk {
visitor: &mut V,
it: &ImportAttributeKey<'a>,
) {
// No `AstKind` for this type
match it {
ImportAttributeKey::Identifier(it) => visitor.visit_identifier_name(it),
ImportAttributeKey::StringLiteral(it) => visitor.visit_string_literal(it),
Expand Down Expand Up @@ -4274,6 +4301,7 @@ pub mod walk {
visitor: &mut V,
it: &ExportDefaultDeclarationKind<'a>,
) {
// No `AstKind` for this type
match it {
ExportDefaultDeclarationKind::FunctionDeclaration(it) => {
let flags = ScopeFlags::Function;
Expand Down
Loading
Loading