refactor(ast): comments for enums with no AstKind in generated code for Visit trait#8796
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 31, 2025
Conversation
github-actions
bot
added
A-ast
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
|
Only affects comments, so merging without review. |
Member
Author
Merge activity
|
… for `Visit` trait (#8796) "No `AstKind` for this type" comments appear in `walk_*` functions for structs with no `AstKind`. Do the same for enums.
graphite-app
bot
force-pushed
the
01-31-refactor_ast_comments_for_enums_with_no_astkind_in_generated_code_for_visit_trait
branch
from
3afb67e to
d4eee50
Compare
graphite-app
bot
deleted the
01-31-refactor_ast_comments_for_enums_with_no_astkind_in_generated_code_for_visit_trait
branch
CodSpeed Performance ReportMerging #8796 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"No
AstKindfor this type" comments appear inwalk_*functions for structs with noAstKind. Do the same for enums.