fix(transformer/arrow-functions): visit arguments to super() call

[overlookmotel]

Follow-on after #8482.

Fix an edge case in arrow functions transform when inserting _this = this after super(). It is possible (though bizarre) for super() to contain another super() call. This will throw an error when evaluating the outer super(), but it can still be observable in some cases.

let f;
class S {}
class C extends S {
  constructor(x) {
    super(super(), this.x = x, f = async () => this);
  }
}

try { new C(123) } catch {}

const c = await f();
assert(c.x === 123);

So, before bailing out from searching for more super()s in class constructor, visit the super() call's arguments.

[overlookmotel]

• fix(transformer/arrow-functions): visit arguments to super() call #8494 👈 (View in Graphite)
• test(transformer): handle more exec tests #8493
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #8494 will not alter performance

_{Comparing 01-14-fix_transformer_arrow-functions_visit_arguments_to_super_call (9963533) with main (6585463)}

Summary

✅ 32 untouched benchmarks

[Dunqing]

It's super rare. Anyway it would be better if oxc could cover all edge cases

[Dunqing]

Merge activity

• Jan 14, 9:06 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jan 14, 9:06 PM EST: A user added this pull request to the Graphite merge queue.
• Jan 14, 9:12 PM EST: A user merged this pull request with the Graphite merge queue.

[overlookmotel]

Yes, it's super-rare. Would only appear in minified code - a real person would not write code like this. But super() is only called with simple values e.g. super(x, y), and visiting x, y is very cheap, so I would hope this costs almost nothing in almost all cases.