test(transformer): handle more exec tests#8493
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 15, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-test
Dunqing
approved these changes
Jan 15, 2025
Contributor
Merge activity
|
Some of Babel's exec tests contain a return statement at top level, in order to return a Promise. e.g. https://github.com/babel/babel/blob/ad572fd1a1615f53c4e3b85941760bdb1a1aefd9/packages/babel-plugin-transform-private-methods/test/fixtures/private-method-loose/async/exec.js These test files could not be parsed due to illegal position of `return`, and the tests were silently excluded. This PR: 1. Includes those tests by passing `allow_return_outside_function: true` option to parser for exec tests. 2. Includes a "transform error" message in snapshot for any exec tests which produce errors in parser/transformer.
Dunqing
force-pushed
the
01-14-test_transformer_handle_more_exec_tests
branch
from
dcb74e0 to
ca02c16
Compare
graphite-app
bot
deleted the
01-14-test_transformer_handle_more_exec_tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of Babel's exec tests contain a return statement at top level, in order to return a Promise.
e.g. https://github.com/babel/babel/blob/ad572fd1a1615f53c4e3b85941760bdb1a1aefd9/packages/babel-plugin-transform-private-methods/test/fixtures/private-method-loose/async/exec.js
These test files could not be parsed due to illegal position of
return, and the tests were silently excluded.This PR:
allow_return_outside_function: trueoption to parser for exec tests.