Skip to content

refactor(transformer/class-properties): transform the remaining PrivateFieldExpression in ChainExpression first#7763

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-10-refactor_transformer_class-properties_transform_the_remaining_privatefieldexpression_in_chainexpression_first
Dec 10, 2024
Merged

refactor(transformer/class-properties): transform the remaining PrivateFieldExpression in ChainExpression first#7763
graphite-app[bot] merged 1 commit intomainfrom
12-10-refactor_transformer_class-properties_transform_the_remaining_privatefieldexpression_in_chainexpression_first

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 10, 2024

We need to transform the inner PrivateFieldExpression so that the variable name matches Babel's output as closely as possible.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 10, 2024

CodSpeed Performance Report

Merging #7763 will not alter performance

Comparing 12-10-refactor_transformer_class-properties_transform_the_remaining_privatefieldexpression_in_chainexpression_first (9cacf64) with main (cf2ee06)

Summary

✅ 29 untouched benchmarks

@Dunqing Dunqing force-pushed the 12-10-refactor_transformer_class-properties_transform_the_remaining_privatefieldexpression_in_chainexpression_first branch from d8dce54 to f2e0c21 Compare December 10, 2024 08:04
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 10, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 10, 2024

Merge activity

…teFieldExpression in ChainExpression first (#7763)

We need to transform the inner PrivateFieldExpression so that the variable name matches Babel's output as closely as possible.
@overlookmotel overlookmotel force-pushed the 12-10-fix_transformer_class-properties_output_is_not_the_same_with_babel_when_privatefieldexpression_is_optional branch from 1df9c46 to f42dbdf Compare December 10, 2024 10:35
@overlookmotel overlookmotel force-pushed the 12-10-refactor_transformer_class-properties_transform_the_remaining_privatefieldexpression_in_chainexpression_first branch from f2e0c21 to 9cacf64 Compare December 10, 2024 10:36
Base automatically changed from 12-10-fix_transformer_class-properties_output_is_not_the_same_with_babel_when_privatefieldexpression_is_optional to main December 10, 2024 10:49
@graphite-app graphite-app bot merged commit 9cacf64 into main Dec 10, 2024
@graphite-app graphite-app bot deleted the 12-10-refactor_transformer_class-properties_transform_the_remaining_privatefieldexpression_in_chainexpression_first branch December 10, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants