Skip to content

test(transformer/class-properties): overrides optional-chain-related tests#7749

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-10-test_transformer_class-properties_overrides_optional-chain-related_tests
Dec 10, 2024
Merged

test(transformer/class-properties): overrides optional-chain-related tests#7749
graphite-app[bot] merged 1 commit intomainfrom
12-10-test_transformer_class-properties_overrides_optional-chain-related_tests

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 9, 2024

These tests only variable names difference from Babel's output, which is caused by transforming order.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Dec 9, 2024
@Dunqing Dunqing force-pushed the 12-09-fix_transformer_class-properties_output_is_not_the_same_with_babel_when_callee_has_optional branch from b514687 to cdf5eae Compare December 10, 2024 07:50
@Dunqing Dunqing force-pushed the 12-10-test_transformer_class-properties_overrides_optional-chain-related_tests branch from b94babb to 4862f2d Compare December 10, 2024 07:50
@Dunqing Dunqing changed the base branch from 12-09-fix_transformer_class-properties_output_is_not_the_same_with_babel_when_callee_has_optional to 12-10-refactor_transformer_class-properties_transform_the_remaining_privatefieldexpression_in_chainexpression_first December 10, 2024 07:50
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 10, 2024

CodSpeed Performance Report

Merging #7749 will not alter performance

Comparing 12-10-test_transformer_class-properties_overrides_optional-chain-related_tests (4862f2d) with 12-10-refactor_transformer_class-properties_transform_the_remaining_privatefieldexpression_in_chainexpression_first (d8dce54)

Summary

✅ 29 untouched benchmarks

@Dunqing Dunqing force-pushed the 12-10-refactor_transformer_class-properties_transform_the_remaining_privatefieldexpression_in_chainexpression_first branch from d8dce54 to f2e0c21 Compare December 10, 2024 08:04
@Dunqing Dunqing force-pushed the 12-10-test_transformer_class-properties_overrides_optional-chain-related_tests branch 4 times, most recently from b47ad0c to 89ac793 Compare December 10, 2024 08:42
@Dunqing Dunqing marked this pull request as ready for review December 10, 2024 09:15
Copy link
Member

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to double-check this, but it was taking ages to rename all the vars. So I'm assuming it's correct.

I can see why this frustrated you a lot!

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 10, 2024
Copy link
Member

overlookmotel commented Dec 10, 2024

Merge activity

  • Dec 10, 5:31 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 10, 5:31 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 10, 5:59 AM EST: A user merged this pull request with the Graphite merge queue.

…tests (#7749)

These tests only variable names difference from Babel's output, which is caused by transforming order.
overlookmotel pushed a commit that referenced this pull request Dec 10, 2024
…when callee has optional (#7748)

Part of #7749. It is just an output mismatch problem, not affecting runtime behavior.
overlookmotel pushed a commit that referenced this pull request Dec 10, 2024
…when PrivateFieldExpression is optional (#7762)

Part of #7749
@overlookmotel overlookmotel force-pushed the 12-10-refactor_transformer_class-properties_transform_the_remaining_privatefieldexpression_in_chainexpression_first branch from f2e0c21 to 9cacf64 Compare December 10, 2024 10:36
@overlookmotel overlookmotel force-pushed the 12-10-test_transformer_class-properties_overrides_optional-chain-related_tests branch from 89ac793 to 19a8aa5 Compare December 10, 2024 10:36
Base automatically changed from 12-10-refactor_transformer_class-properties_transform_the_remaining_privatefieldexpression_in_chainexpression_first to main December 10, 2024 10:55
@graphite-app graphite-app bot merged commit 19a8aa5 into main Dec 10, 2024
@graphite-app graphite-app bot deleted the 12-10-test_transformer_class-properties_overrides_optional-chain-related_tests branch December 10, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants