Skip to content

perf(transformer/logic-assignment-operator): inline enter_expression visitor #7744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Dec 9, 2024
Merged

perf(transformer/logic-assignment-operator): inline enter_expression visitor #7744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions crates/oxc_transformer/src/es2021/logical_assignment_operators.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ use oxc_allocator::CloneIn;
use oxc_ast::ast::*;
use oxc_semantic::ReferenceFlags;
use oxc_span::SPAN;
use oxc_syntax::operator::{AssignmentOperator, LogicalOperator};
use oxc_traverse::{BoundIdentifier, MaybeBoundIdentifier, Traverse, TraverseCtx};

use crate::TransformCtx;
Expand All @@ -74,16 +73,28 @@ impl<'a, 'ctx> LogicalAssignmentOperators<'a, 'ctx> {
}

impl<'a, 'ctx> Traverse<'a> for LogicalAssignmentOperators<'a, 'ctx> {
// `#[inline]` because this is a hot path, and most `Expression`s are not `AssignmentExpression`s
// with a logical operator. So we want to bail out as fast as possible for everything else,
// without the cost of a function call.
#[inline]
fn enter_expression(&mut self, expr: &mut Expression<'a>, ctx: &mut TraverseCtx<'a>) {
let Expression::AssignmentExpression(assignment_expr) = expr else { return };

// `&&=` `||=` `??=`
let operator = match assignment_expr.operator {
AssignmentOperator::LogicalAnd => LogicalOperator::And,
AssignmentOperator::LogicalOr => LogicalOperator::Or,
AssignmentOperator::LogicalNullish => LogicalOperator::Coalesce,
_ => return,
};
let Some(operator) = assignment_expr.operator.to_logical_operator() else { return };

self.transform_logical_assignment(expr, operator, ctx);
}
}

impl<'a, 'ctx> LogicalAssignmentOperators<'a, 'ctx> {
fn transform_logical_assignment(
&mut self,
expr: &mut Expression<'a>,
operator: LogicalOperator,
ctx: &mut TraverseCtx<'a>,
) {
let Expression::AssignmentExpression(assignment_expr) = expr else { unreachable!() };

// `a &&= c` -> `a && (a = c);`
// ^ ^ assign_target
Expand Down Expand Up @@ -122,9 +133,7 @@ impl<'a, 'ctx> Traverse<'a> for LogicalAssignmentOperators<'a, 'ctx> {

*expr = logical_expr;
}
}

impl<'a, 'ctx> LogicalAssignmentOperators<'a, 'ctx> {
fn convert_identifier(
ident: &IdentifierReference<'a>,
ctx: &mut TraverseCtx<'a>,
Expand Down