perf(transformer/logic-assignment-operator): inline enter_expression visitor#7744
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 9, 2024
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-transformer
CodSpeed Performance ReportMerging #7744 will improve performances by 3.16%Comparing Summary
Benchmarks breakdown
|
Member
Merge activity
|
…` visitor (#7744) Optimization. Inline `enter_expression` visitor, and reduce the size of the function, to keep the path for "nothing to do here, bail out" as fast and compact as possible. From CodSpeed results, it looks like `enter_expression` was already being inlined as perf gain is not the usual +5% we see for inlining `enter_expression` when it wasn't already. But reducing the size of the visitor function still nets a +1% perf gain.
Dunqing
force-pushed
the
12-09-perf_transformer_logic-assignment-operator_inline_enter_expression_visitor
branch
from
1ddea05 to
463fc5f
Compare
graphite-app
bot
deleted the
12-09-perf_transformer_logic-assignment-operator_inline_enter_expression_visitor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimization. Inline
enter_expressionvisitor, and reduce the size of the function, to keep the path for "nothing to do here, bail out" as fast and compact as possible.From CodSpeed results, it looks like
enter_expressionwas already being inlined as perf gain is not the usual +5% we see for inliningenter_expressionwhen it wasn't already. But reducing the size of the visitor function still nets a +1% perf gain.