test(linter): port react-jsx-uses-vars rules to no_unused_vars#7731
Merged
camc314 merged 2 commits intooxc-project:mainfrom Dec 8, 2024
Merged
test(linter): port react-jsx-uses-vars rules to no_unused_vars#7731camc314 merged 2 commits intooxc-project:mainfrom
react-jsx-uses-vars rules to no_unused_vars#7731camc314 merged 2 commits intooxc-project:mainfrom
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-linter
CodSpeed Performance ReportMerging #7731 will not alter performanceComparing Summary
|
camc314
reviewed
Dec 8, 2024
crates/oxc_linter/src/rules/eslint/no_unused_vars/tests/react.rs
Outdated
Show resolved
Hide resolved
camc314
changed the title
react-jsx-uses-vars rules to no_unused_vars
github-actions
bot
added
the
C-test
Boshen
added a commit
that referenced
this pull request
Dec 10, 2024
## [0.15.0] - 2024-12-10 - 39b9c5d linter: [**BREAKING**] Remove unmaintained security plugin (#7773) (Boshen) ### Features - 065f7dc linter: Support `expectTypeOf`, `assert` and `assertType` in `vitest/expect-expect` (#7742) (Yuichiro Yamashita) - 3d5f0a1 linter/no_restricted_imports: Add the no_restricted_imports rules (#7629) (Guillaume Piedigrossi) ### Bug Fixes - ad27b20 linter: Only resolve esm files for import plugin (#7720) (Boshen) - 5e6053f linter: False positive in `eslint/yoda` (#7719) (dalaoshu) ### Refactor - c6a19aa linter: Remove unused `serde` features (#7738) (Boshen) - b9a2b35 linter: Remove `aho-corasick` (#7718) (Boshen) ### Testing - 62f0a22 linter: Port `react-jsx-uses-vars` rules to no_unused_vars (#7731) (Tyler Earls) - 02f9903 linter: Add regression tests for `import/namespace` (#7723) (dalaoshu) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the test cases from eslint-plugin-react/jsx-uses-vars to a
react.rsfile in theno_unused_varstests module.After adding the new tests, they immediately passed without any source code changes required. It would seem that the linter already supported this rule, but now there will be tests to support it.