Skip to content

fix(linter): false positive in eslint/yoda#7719

Merged
camc314 merged 1 commit intooxc-project:mainfrom
shulaoda:fix/eslint-yoda
Dec 7, 2024
Merged

fix(linter): false positive in eslint/yoda#7719
camc314 merged 1 commit intooxc-project:mainfrom
shulaoda:fix/eslint-yoda

Conversation

@shulaoda
Copy link
Contributor

@shulaoda shulaoda commented Dec 7, 2024

closes #7714

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 7, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Dec 7, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 7, 2024

CodSpeed Performance Report

Merging #7719 will not alter performance

Comparing shulaoda:fix/eslint-yoda (b570a8f) with main (b9a2b35)

Summary

✅ 29 untouched benchmarks

@camc314 camc314 merged commit 5e6053f into oxc-project:main Dec 7, 2024
@shulaoda shulaoda deleted the fix/eslint-yoda branch December 7, 2024 15:13
Boshen added a commit that referenced this pull request Dec 10, 2024
## [0.15.0] - 2024-12-10

- 39b9c5d linter: [**BREAKING**] Remove unmaintained security plugin
(#7773) (Boshen)

### Features

- 065f7dc linter: Support `expectTypeOf`, `assert` and `assertType` in
`vitest/expect-expect` (#7742) (Yuichiro Yamashita)
- 3d5f0a1 linter/no_restricted_imports: Add the no_restricted_imports
rules (#7629) (Guillaume Piedigrossi)

### Bug Fixes

- ad27b20 linter: Only resolve esm files for import plugin (#7720)
(Boshen)
- 5e6053f linter: False positive in `eslint/yoda` (#7719) (dalaoshu)

### Refactor

- c6a19aa linter: Remove unused `serde` features (#7738) (Boshen)
- b9a2b35 linter: Remove `aho-corasick` (#7718) (Boshen)

### Testing

- 62f0a22 linter: Port `react-jsx-uses-vars` rules to no_unused_vars
(#7731) (Tyler Earls)
- 02f9903 linter: Add regression tests for `import/namespace` (#7723)
(dalaoshu)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic byte index 3 is not a char boundary in crates/oxc_span/src/span/mod.rs (in new yoda eslint rules)

2 participants