Skip to content

fix(napi/transform): respect options.sourcemap for id #7590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 2 commits into from
Dec 3, 2024
Merged

fix(napi/transform): respect options.sourcemap for id #7590

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a49ca3
fix(napi/transform): respect `options.sourcemap`
sxzz Dec 3, 2024
1bf3a21
add test
Boshen Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions napi/transform/src/isolated_declaration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,12 @@ pub fn isolated_declaration(
)
.build(&ret.program);

let source_map_path = match options.sourcemap {
Some(true) => Some(source_path.to_path_buf()),
_ => None,
};
let codegen_ret = CodeGenerator::new()
.with_options(CodegenOptions {
source_map_path: Some(source_path.to_path_buf()),
..CodegenOptions::default()
})
.with_options(CodegenOptions { source_map_path, ..CodegenOptions::default() })
.build(&transformed_ret.program);

let errors = ret.errors.into_iter().chain(transformed_ret.errors).collect();
Expand Down