Skip to content

fix(napi/transform): respect options.sourcemap for id#7590

Merged
Boshen merged 2 commits intooxc-project:mainfrom
sxzz:fix/transform-sourcemap
Dec 3, 2024
Merged

fix(napi/transform): respect options.sourcemap for id#7590
Boshen merged 2 commits intooxc-project:mainfrom
sxzz:fix/transform-sourcemap

Conversation

@sxzz
Copy link
Member

@sxzz sxzz commented Dec 3, 2024

Don't pass source_map_path if options.sourcemap is undefined or false; then, IsolatedDeclarationsResult.map should be undefined.

Downstream issue unplugin/unplugin-isolated-decl#42

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the C-bug Category - Bug label Dec 3, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #7590 will not alter performance

Comparing sxzz:fix/transform-sourcemap (1bf3a21) with main (b553d6f)

Summary

✅ 30 untouched benchmarks

@Boshen
Copy link
Member

Boshen commented Dec 3, 2024

Let me add a test.

@Boshen Boshen self-assigned this Dec 3, 2024
@Boshen Boshen changed the title fix(napi/transform): respect options.sourcemap fix(napi/transform): respect options.sourcemap for id Dec 3, 2024
@Boshen Boshen merged commit be2293a into oxc-project:main Dec 3, 2024
@sxzz sxzz deleted the fix/transform-sourcemap branch December 3, 2024 03:59
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants