fix(transformer/async-to-generator): correct the SymbolFlags of function id in module#7470
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 26, 2024
Conversation
This was referenced Nov 25, 2024
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-transformer
Dunqing
force-pushed
the
11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags
branch
from
2941100 to
db6c375
Compare
Dunqing
force-pushed
the
11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module
branch
from
2918ec6 to
7c17a75
Compare
CodSpeed Performance ReportMerging #7470 will not alter performanceComparing Summary
|
Dunqing
force-pushed
the
11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags
branch
from
db6c375 to
ad649f6
Compare
Dunqing
force-pushed
the
11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module
branch
from
7c17a75 to
33bc9a6
Compare
Dunqing
force-pushed
the
11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags
branch
from
ad649f6 to
6fcacb4
Compare
Dunqing
force-pushed
the
11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module
branch
from
33bc9a6 to
aa4cd47
Compare
Dunqing
force-pushed
the
11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags
branch
from
6fcacb4 to
8e53319
Compare
Dunqing
force-pushed
the
11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module
branch
3 times, most recently
from
1bff2bf to
72ec0b8
Compare
Dunqing
force-pushed
the
11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags
branch
from
8e53319 to
bc8fff8
Compare
Dunqing
force-pushed
the
11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module
branch
from
72ec0b8 to
714169f
Compare
Dunqing
force-pushed
the
11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags
branch
from
bc8fff8 to
20fc793
Compare
Dunqing
force-pushed
the
11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module
branch
from
714169f to
7183138
Compare
Dunqing
force-pushed
the
11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags
branch
from
20fc793 to
aeb9365
Compare
Dunqing
force-pushed
the
11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module
branch
from
7183138 to
5c3fb58
Compare
overlookmotel
approved these changes
Nov 26, 2024
Member
Merge activity
|
overlookmotel
force-pushed
the
11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags
branch
2 times, most recently
from
9dd0532 to
7969be2
Compare
overlookmotel
force-pushed
the
11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module
branch
from
5c3fb58 to
b673764
Compare
…ction id in module (#7470)
overlookmotel
force-pushed
the
11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags
branch
from
7969be2 to
37842c1
Compare
overlookmotel
force-pushed
the
11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module
branch
from
b673764 to
58a125f
Compare
Base automatically changed from
11-25-fix_transformer_object-rest-spread_generate_catch_variable_binding_with_correct_symbolflags
to
main
November 26, 2024 12:04
graphite-app
bot
deleted the
11-25-fix_transformer_async-to-generator_correct_the_symbolflags_of_function_id_in_module
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 24, 2025
#7479) close #7402 related: #7470 The purpose of this PR is to keep the SymbolFlags of the function consistent. Always use `SymbolFlags::Function` for the function id symbol, to avoid adding extra logic to find accurate `SymbolFlags` for the function in `transformer`. This change adds a fallback redeclaration check for case `async function foo() {}; var foo;` in `SemanticBuilder::check_redeclaraion`. No performance difference here because redeclaration is always rare.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.