fix(semantic): function is value#7402
Closed
ShuiRuTian wants to merge 1 commit intooxc-project:mainfrom
Closed
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
Author
|
And a stupid question, just out of curious... The implementation seems to refer typescript's design. Then why it is missed? |
CodSpeed Performance ReportMerging #7402 will not alter performanceComparing Summary
|
overlookmotel
changed the title
Member
|
This breaks many tests 🤔 |
Contributor
Author
Yeah, strange, investigating... |
Member
|
The |
Member
|
I'll follow this up in #7479 |
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 24, 2025
#7479) close #7402 related: #7470 The purpose of this PR is to keep the SymbolFlags of the function consistent. Always use `SymbolFlags::Function` for the function id symbol, to avoid adding extra logic to find accurate `SymbolFlags` for the function in `transformer`. This change adds a fallback redeclaration check for case `async function foo() {}; var foo;` in `SemanticBuilder::check_redeclaraion`. No performance difference here because redeclaration is always rare.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functionshould beValue