Skip to content

Comments

refactor(ast)!: remove AstKind::FinallyClause#6744

Merged
graphite-app[bot] merged 1 commit intomainfrom
remove-finally-clause
Oct 21, 2024
Merged

refactor(ast)!: remove AstKind::FinallyClause#6744
graphite-app[bot] merged 1 commit intomainfrom
remove-finally-clause

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Oct 21, 2024

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024
@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 21, 2024
@Boshen Boshen force-pushed the remove-finally-clause branch from 39dc0f8 to 6b53708 Compare October 21, 2024 14:26
Copy link
Member Author

Boshen commented Oct 21, 2024

Merge activity

  • Oct 21, 10:26 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 21, 10:31 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 21, 10:45 AM EDT: A user merged this pull request with the Graphite merge queue.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 21, 2024

CodSpeed Performance Report

Merging #6744 will not alter performance

Comparing remove-finally-clause (1248557) with main (85d5220)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen force-pushed the remove-finally-clause branch from 6b53708 to 1248557 Compare October 21, 2024 14:37
@graphite-app graphite-app bot merged commit 1248557 into main Oct 21, 2024
@graphite-app graphite-app bot deleted the remove-finally-clause branch October 21, 2024 14:45
Boshen pushed a commit that referenced this pull request Oct 22, 2024
#6740 and #6744 removed visitor type aliases (`#[visit(as(ClassHeritage))]`). Remove support for `#[visit(as(...))]` from `oxc_ast_tools`, since it's now dead code.
Boshen pushed a commit that referenced this pull request Oct 22, 2024
#6740 and #6744 removed visitor type aliases (`#[visit(as(ClassHeritage))]`). Remove support for `#[visit(as(...))]` from `oxc_ast_tools`, since it's now dead code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST A-linter Area - Linter A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant