Skip to content

Comments

fix(ast)!: remove AstKind::ExpressionArrayElement and AstKind::ClassHeritage#6740

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-21-fix_ast_remove_astkind_expressionarrayelement_
Oct 21, 2024
Merged

fix(ast)!: remove AstKind::ExpressionArrayElement and AstKind::ClassHeritage#6740
graphite-app[bot] merged 1 commit intomainfrom
10-21-fix_ast_remove_astkind_expressionarrayelement_

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Oct 21, 2024

closes #6392

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter A-ast Area - AST A-ast-tools Area - AST tools C-bug Category - Bug labels Oct 21, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 21, 2024

CodSpeed Performance Report

Merging #6740 will not alter performance

Comparing 10-21-fix_ast_remove_astkind_expressionarrayelement_ (202c7f6) with main (ab8aa2f)

Summary

✅ 30 untouched benchmarks

@github-actions github-actions bot added the A-semantic Area - Semantic label Oct 21, 2024
@Boshen Boshen changed the title fix(ast)!: remove AstKind::ExpressionArrayElement fix(ast)!: remove AstKind::ExpressionArrayElement and AstKind::ClassHeritage Oct 21, 2024
@Boshen Boshen force-pushed the 10-21-fix_ast_remove_astkind_expressionarrayelement_ branch from 2494585 to ce1a654 Compare October 21, 2024 13:25
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024
Copy link
Member Author

Boshen commented Oct 21, 2024

Merge activity

  • Oct 21, 9:27 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 21, 9:30 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 21, 9:35 AM EDT: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 10-21-fix_ast_remove_astkind_expressionarrayelement_ branch from ce1a654 to 202c7f6 Compare October 21, 2024 13:30
@graphite-app graphite-app bot merged commit 202c7f6 into main Oct 21, 2024
@graphite-app graphite-app bot deleted the 10-21-fix_ast_remove_astkind_expressionarrayelement_ branch October 21, 2024 13:35
Boshen pushed a commit that referenced this pull request Oct 22, 2024
#6740 and #6744 removed visitor type aliases (`#[visit(as(ClassHeritage))]`). Remove support for `#[visit(as(...))]` from `oxc_ast_tools`, since it's now dead code.
Boshen pushed a commit that referenced this pull request Oct 22, 2024
#6740 and #6744 removed visitor type aliases (`#[visit(as(ClassHeritage))]`). Remove support for `#[visit(as(...))]` from `oxc_ast_tools`, since it's now dead code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools A-linter Area - Linter A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ast: ArrayExpressionElement vs ExpressionArrayElement is confusing

1 participant