Skip to content

perf(traverse): UIDs cache store used names as single FxHashSet#5624

Closed
overlookmotel wants to merge 1 commit into09-08-perf_traverse_uids_cache_store_used_names_as_fxhashset_instead_of_vec_from
09-08-perf_traverse_uids_cache_store_used_names_as_single_fxhashset_
Closed

perf(traverse): UIDs cache store used names as single FxHashSet#5624
overlookmotel wants to merge 1 commit into09-08-perf_traverse_uids_cache_store_used_names_as_fxhashset_instead_of_vec_from
09-08-perf_traverse_uids_cache_store_used_names_as_single_fxhashset_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 8, 2024

Experiment.

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Sep 8, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@overlookmotel overlookmotel marked this pull request as ready for review September 8, 2024 22:40
@overlookmotel overlookmotel marked this pull request as draft September 8, 2024 22:41
@overlookmotel overlookmotel force-pushed the 09-08-perf_traverse_uids_cache_store_used_names_as_single_fxhashset_ branch from 860408c to 5bc046a Compare September 8, 2024 22:43
@overlookmotel overlookmotel force-pushed the 09-08-perf_traverse_uids_cache_store_used_names_as_single_fxhashset_ branch from 5bc046a to df27ec3 Compare September 8, 2024 22:43
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 8, 2024

CodSpeed Performance Report

Merging #5624 will not alter performance

Comparing 09-08-perf_traverse_uids_cache_store_used_names_as_single_fxhashset_ (df27ec3) with 09-08-perf_traverse_uids_cache_store_used_names_as_fxhashset_instead_of_vec_ (12b0738)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen deleted the 09-08-perf_traverse_uids_cache_store_used_names_as_single_fxhashset_ branch February 17, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant