Skip to content

perf(traverse): UIDs cache store used names as FxHashSet instead of Vec#5623

Closed
overlookmotel wants to merge 2 commits into
09-08-perf_traverse_generate_uid_cache_available_binding_namesfrom
09-08-perf_traverse_uids_cache_store_used_names_as_fxhashset_instead_of_vec_
Closed

perf(traverse): UIDs cache store used names as FxHashSet instead of Vec#5623
overlookmotel wants to merge 2 commits into
09-08-perf_traverse_generate_uid_cache_available_binding_namesfrom
09-08-perf_traverse_uids_cache_store_used_names_as_fxhashset_instead_of_vec_

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Sep 8, 2024

Follow-on after #5611. Store existing var names in uid_names as FxHashSet instead of a Vec.

WIP. Not sure if this will improve perf or not, since often the Vecs would have few entries.

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Sep 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Copy Markdown
Member Author

overlookmotel commented Sep 8, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@overlookmotel overlookmotel marked this pull request as ready for review September 8, 2024 22:17
@overlookmotel overlookmotel marked this pull request as draft September 8, 2024 22:17
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Sep 8, 2024

CodSpeed Performance Report

Merging #5623 will not alter performance

Comparing 09-08-perf_traverse_uids_cache_store_used_names_as_fxhashset_instead_of_vec_ (12b0738) with 09-08-perf_traverse_generate_uid_cache_available_binding_names (c7c4d6f)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 09-08-perf_traverse_generate_uid_cache_available_binding_names branch from c7c4d6f to a3ab781 Compare September 9, 2024 08:51
@Boshen Boshen deleted the 09-08-perf_traverse_uids_cache_store_used_names_as_fxhashset_instead_of_vec_ branch February 17, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant