Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): add fixer for no-empty #5276

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

camc314
Copy link
Collaborator

@camc314 camc314 commented Aug 27, 2024

adds a suggestion for no-empty eslint lint rule

@camc314 camc314 marked this pull request as ready for review August 27, 2024 21:16
@github-actions github-actions bot added the A-linter Area - Linter label Aug 27, 2024
Copy link
Collaborator Author

camc314 commented Aug 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camc314 and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Aug 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Aug 27, 2024

CodSpeed Performance Report

Merging #5276 will not alter performance

Comparing c/08-27-feat_linter_add_fixer_for_no-empty_ (6633972) with main (7fa2fa3)

Summary

✅ 29 untouched benchmarks

@camc314 camc314 requested a review from DonIsaac August 27, 2024 21:25
@camc314 camc314 force-pushed the c/08-27-feat_linter_add_fixer_for_no-empty_ branch from 92b8d9e to 2598c7b Compare August 28, 2024 07:17
@camc314 camc314 requested a review from DonIsaac August 28, 2024 07:17
@camc314 camc314 force-pushed the c/08-27-feat_linter_add_fixer_for_no-empty_ branch 2 times, most recently from babd80f to 32c998f Compare August 28, 2024 12:37
@camc314 camc314 force-pushed the c/08-27-feat_linter_add_fixer_for_no-empty_ branch from 32c998f to 4e8ef56 Compare August 28, 2024 14:58
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Aug 28, 2024
Copy link

graphite-app bot commented Aug 28, 2024

Merge activity

  • Aug 28, 11:04 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 28, 11:06 AM EDT: camc314 added this pull request to the Graphite merge queue.
  • Aug 28, 11:09 AM EDT: camc314 merged this pull request with the Graphite merge queue.

adds a suggestion for `no-empty` eslint lint rule
@camc314 camc314 force-pushed the c/08-27-feat_linter_add_fixer_for_no-empty_ branch from 4e8ef56 to 6633972 Compare August 28, 2024 15:06
@graphite-app graphite-app bot merged commit 6633972 into main Aug 28, 2024
24 checks passed
@graphite-app graphite-app bot deleted the c/08-27-feat_linter_add_fixer_for_no-empty_ branch August 28, 2024 15:09
Boshen added a commit that referenced this pull request Aug 29, 2024
## [0.9.1] - 2024-08-29

### Features

- 6633972 linter: Add fixer for `no-empty` (#5276) (camc314)
- a58e448 linter/eslint: Add fixer to `no-var` (#5144) (camc314)
- a6e9769 linter/jsx-a11y: Add `label-has-associated-control` (#5163)
(Billy Levin)
- c8e8532 linter/unicorn: Add fixer to `throw-new-error` (#5275)
(camc314)
- 7ccde4b linter/unicorn: Add fixer to `prefer-date-now` (#5147)
(camc314)

### Bug Fixes

- 76e86f8 linter: Eslint-plugin-unicorn prefer-spread wrong linter
suggestion on variables of type string (#5265) (Arian94)
- b39544e linter/jest: Fixer for `prefer-jest-mocked` creates invalid
LHS expressions (#5243) (camc314)
- 9953fa5 linter/no-null: Incorrect fixer for `NullLiteral` within
`ReturnStatement` (#5247) (Dunqing)
- 318479e linter/no-unused-vars: Mark the class/function in the new
expression as used (#5306) (magic-akari)

### Refactor

- fa1d460 linter: Clean up Fixer and Message (#5308) (DonIsaac)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants