feat(linter/jsx-a11y): add label-has-associated-control
#5163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #5163 will not alter performanceComparing Summary
|
|
From a cursory glance, this looks awesome! Thanks for the PR 😄 With one so large, I'd like to get a few other pairs of eyes on this before merging. |
DonIsaac
reviewed
Aug 25, 2024
crates/oxc_linter/src/rules/jsx_a11y/label_has_associated_control.rs
Outdated
Show resolved
Hide resolved
crates/oxc_linter/src/rules/jsx_a11y/label_has_associated_control.rs
Outdated
Show resolved
Hide resolved
DonIsaac
approved these changes
Aug 27, 2024
Merge activity
|
DonIsaac
changed the title
label-has-associated-control
This was referenced Aug 29, 2024
Closed
Closed
Closed
Merged
Boshen
added a commit
that referenced
this pull request
Aug 29, 2024
## [0.9.1] - 2024-08-29 ### Features - 6633972 linter: Add fixer for `no-empty` (#5276) (camc314) - a58e448 linter/eslint: Add fixer to `no-var` (#5144) (camc314) - a6e9769 linter/jsx-a11y: Add `label-has-associated-control` (#5163) (Billy Levin) - c8e8532 linter/unicorn: Add fixer to `throw-new-error` (#5275) (camc314) - 7ccde4b linter/unicorn: Add fixer to `prefer-date-now` (#5147) (camc314) ### Bug Fixes - 76e86f8 linter: Eslint-plugin-unicorn prefer-spread wrong linter suggestion on variables of type string (#5265) (Arian94) - b39544e linter/jest: Fixer for `prefer-jest-mocked` creates invalid LHS expressions (#5243) (camc314) - 9953fa5 linter/no-null: Incorrect fixer for `NullLiteral` within `ReturnStatement` (#5247) (Dunqing) - 318479e linter/no-unused-vars: Mark the class/function in the new expression as used (#5306) (magic-akari) ### Refactor - fa1d460 linter: Clean up Fixer and Message (#5308) (DonIsaac) Co-authored-by: Boshen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the jsx-a11y/label-has-associated-control rule.
This implementation differs slightly from the current version of the ESLint plugin, but I've opened PRs for these differences which I assume will be released in the next version:
label-has-associated-control: ignore undetermined label text jsx-eslint/eslint-plugin-jsx-a11y#1004label-has-associated-control: add additional error message jsx-eslint/eslint-plugin-jsx-a11y#1007Milestone reference: #1141