Skip to content

refactor(parser): use function instead of trait to parse normal lists#4003

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-01-refactor_parser_use_function_instead_of_trait_to_parse_lists
Jul 1, 2024
Merged

refactor(parser): use function instead of trait to parse normal lists#4003
graphite-app[bot] merged 1 commit intomainfrom
07-01-refactor_parser_use_function_instead_of_trait_to_parse_lists

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jul 1, 2024

To reduce boilerplate and code noise.

relates #3887

@github-actions github-actions bot added the A-parser Area - Parser label Jul 1, 2024
Copy link
Member Author

Boshen commented Jul 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

@Boshen Boshen force-pushed the 07-01-refactor_parser_use_function_instead_of_trait_to_parse_lists branch from d5bd9f5 to d0eac46 Compare July 1, 2024 15:57
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 1, 2024

Merge activity

@graphite-app graphite-app bot merged commit d0eac46 into main Jul 1, 2024
@graphite-app graphite-app bot deleted the 07-01-refactor_parser_use_function_instead_of_trait_to_parse_lists branch July 1, 2024 16:03
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 1, 2024

CodSpeed Performance Report

Merging #4003 will not alter performance

Comparing 07-01-refactor_parser_use_function_instead_of_trait_to_parse_lists (d0eac46) with main (23038ad)

Summary

✅ 28 untouched benchmarks

@github-actions github-actions bot mentioned this pull request Jul 2, 2024
Boshen added a commit that referenced this pull request Jul 2, 2024
## [0.16.3] - 2024-07-02

### Features

- b257d53 linter: Support report
`@typescript-eslint/consistent-type-imports` (#3895) (mysteryven)

### Bug Fixes

- 23038ad codegen: Print `TSFunctionType` inside `TSTypeAssertion`
(#3999) (Boshen)
- d995f94 semantic: Resolve reference incorrectly when a parameter
references a parameter that hasn't been defined yet (#4004) (Dunqing)
- bdee156 transformer/typescript: `declare class` incorrectly preserved
as runtime class (#3997) (Dunqing)
- a50ce3d transformer/typescript: Missing initializer for class
constructor arguments with `private` and `protected` modifier (#3996)
(Dunqing)

### Refactor

- 0fe22a8 ast: Reorder fields to reflect their visit order. (#3994)
(rzvxa)
- d0eac46 parser: Use function instead of trait to parse normal lists
(#4003) (Boshen)

Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant