fix(transformer/typescript): missing initializer for class constructor arguments with private and protected modifier#3996
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 1, 2024
Conversation
Dunqing
changed the title
protected modifierprivate and protected modifier
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #3996 will not alter performanceComparing Summary
|
Contributor
Merge activity
|
Dunqing
force-pushed
the
07-01-fix_transformer_typescript_missing_initializer_for_class_constructor_arguments_with_private_and_protected_modifier
branch
2 times, most recently
from
771e001 to
abddd20
Compare
Dunqing
changed the base branch from
main
to
07-01-chore_ci_link-check_ignore_all_fixtures
Boshen
changed the base branch from
07-01-chore_ci_link-check_ignore_all_fixtures
to
main
Dunqing
force-pushed
the
07-01-fix_transformer_typescript_missing_initializer_for_class_constructor_arguments_with_private_and_protected_modifier
branch
from
abddd20 to
cf34785
Compare
Dunqing
changed the base branch from
main
to
07-01-chore_ci_link-check_ignore_all_fixtures
Boshen
force-pushed
the
07-01-fix_transformer_typescript_missing_initializer_for_class_constructor_arguments_with_private_and_protected_modifier
branch
from
cf34785 to
ad3ecbe
Compare
Boshen
changed the base branch from
07-01-chore_ci_link-check_ignore_all_fixtures
to
main
Dunqing
force-pushed
the
07-01-fix_transformer_typescript_missing_initializer_for_class_constructor_arguments_with_private_and_protected_modifier
branch
from
ad3ecbe to
a8de816
Compare
Dunqing
changed the base branch from
main
to
07-01-chore_ci_link-check_ignore_all_fixtures
Boshen
changed the base branch from
07-01-chore_ci_link-check_ignore_all_fixtures
to
main
Boshen
force-pushed
the
07-01-fix_transformer_typescript_missing_initializer_for_class_constructor_arguments_with_private_and_protected_modifier
branch
from
a8de816 to
da4f66f
Compare
Dunqing
changed the base branch from
main
to
07-01-chore_ci_link-check_ignore_all_fixtures
Boshen
changed the base branch from
07-01-chore_ci_link-check_ignore_all_fixtures
to
main
Dunqing
force-pushed
the
07-01-fix_transformer_typescript_missing_initializer_for_class_constructor_arguments_with_private_and_protected_modifier
branch
from
da4f66f to
a8de816
Compare
Dunqing
changed the base branch from
main
to
07-01-chore_ci_link-check_ignore_all_fixtures
Boshen
changed the base branch from
07-01-chore_ci_link-check_ignore_all_fixtures
to
main
Boshen
force-pushed
the
07-01-fix_transformer_typescript_missing_initializer_for_class_constructor_arguments_with_private_and_protected_modifier
branch
from
a8de816 to
a50ce3d
Compare
graphite-app
bot
deleted the
07-01-fix_transformer_typescript_missing_initializer_for_class_constructor_arguments_with_private_and_protected_modifier
branch
Merged
Boshen
added a commit
that referenced
this pull request
Jul 2, 2024
## [0.16.3] - 2024-07-02 ### Features - b257d53 linter: Support report `@typescript-eslint/consistent-type-imports` (#3895) (mysteryven) ### Bug Fixes - 23038ad codegen: Print `TSFunctionType` inside `TSTypeAssertion` (#3999) (Boshen) - d995f94 semantic: Resolve reference incorrectly when a parameter references a parameter that hasn't been defined yet (#4004) (Dunqing) - bdee156 transformer/typescript: `declare class` incorrectly preserved as runtime class (#3997) (Dunqing) - a50ce3d transformer/typescript: Missing initializer for class constructor arguments with `private` and `protected` modifier (#3996) (Dunqing) ### Refactor - 0fe22a8 ast: Reorder fields to reflect their visit order. (#3994) (rzvxa) - d0eac46 parser: Use function instead of trait to parse normal lists (#4003) (Boshen) Co-authored-by: Boshen <Boshen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close: #3992