Conversation
MichaReiser
reviewed
Feb 11, 2023
|
|
||
| #[derive(Debug, Default, Clone, Copy, Serialize, PartialEq, Eq)] | ||
| pub struct Node { | ||
| pub start: usize, |
There was a problem hiding this comment.
What's your reasoning behind using usize for node ranges. Isn't a u32 sufficient for "all" reasonable programs (I never tried executing a 4GB JS file)
Member
Author
There was a problem hiding this comment.
Good catch! It ought to be u32 but it was tedious to convert it back to usize in some areas of the code - I think it was mostly the diagnostics printing crate miette.
This was referenced Mar 4, 2023
This was referenced Aug 2, 2025
Copilot AI
added a commit
that referenced
this pull request
Aug 2, 2025
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AST is going to be allocated in a memory arena so it is filled with lifetimes.
A lot of people are uncomfortable with lifetimes, but sadly this is the only way to make the AST fast.