test(oxc_linter): add testing for code fixer#101
Conversation
|
You can keep working on the test cases, we don't need to merge right away. |
shannonrothe
left a comment
There was a problem hiding this comment.
Thanks for the tests – this looks good!
|
@Boshen eslint's test cases contain "message", "no fix", "BOM handle", would you like me test all these cases in this pr or in other pr? |
Parser Benchmark Results - ubuntu-latest |
Parser Benchmark Results - macos-latest |
Parser Benchmark Results - windows-latest |
It would be nice if we add these tests but |
Not sure whether c92e505 is what you want. |
|
Great work! |
Description
Add insertion testing for our code fixer, the test cases are copied from eslint's test cases. The other test cases will be added in the other pr, otherwise this pr would be too big to review.
Store
&'a strinFixerinstead ofString.To avoid overriding the previous fix, we need to record the position of the last fix. As a result, instead of using
Fix::apply, I move the fixing code into theFixer::fixmethod.Related issues
#68