Skip to content

chore(benchmark): enable cfg for linter benchmarks.#3746

Merged
graphite-app[bot] merged 1 commit intomainfrom
06-18-chore_benchmark_enable_cfg_for_linter_benchmarks
Jun 19, 2024
Merged

chore(benchmark): enable cfg for linter benchmarks.#3746
graphite-app[bot] merged 1 commit intomainfrom
06-18-chore_benchmark_enable_cfg_for_linter_benchmarks

Conversation

@rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Jun 18, 2024

The benchmark result on this PR - if we filter out the unstable benchmarks - can also be used to show the total impact of CFG enable rules.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 18, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

rzvxa commented Jun 18, 2024

@rzvxa rzvxa marked this pull request as ready for review June 18, 2024 19:56
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 18, 2024

CodSpeed Performance Report

Merging #3746 will degrade performances by 5.87%

Comparing 06-18-chore_benchmark_enable_cfg_for_linter_benchmarks (49d28c0) with main (1b3cd6c)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 20 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 06-18-chore_benchmark_enable_cfg_for_linter_benchmarks Change
codegen_sourcemap[react.development.js] 2.1 ms 2.2 ms -5.87%
transformer[RadixUIAdoptionSection.jsx] 281.6 µs 261.8 µs +7.58%

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 19, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 19, 2024

Merge activity

  • Jun 19, 1:12 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 19, 1:12 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jun 19, 1:17 AM EDT: Boshen merged this pull request with the Graphite merge queue.

The benchmark result on this PR - if we filter out the unstable benchmarks - can also be used to show the total impact of CFG enable rules.
@Boshen Boshen force-pushed the 06-18-chore_benchmark_enable_cfg_for_linter_benchmarks branch from ece1cf7 to 49d28c0 Compare June 19, 2024 05:13
@graphite-app graphite-app bot merged commit 49d28c0 into main Jun 19, 2024
@graphite-app graphite-app bot deleted the 06-18-chore_benchmark_enable_cfg_for_linter_benchmarks branch June 19, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants