Skip to content

perf(linter): only generate cfg when we have a rule which depends on it.#3745

Closed
rzvxa wants to merge 2 commits into06-18-feat_linter_add_use_cfg_attributefrom
06-18-perf_linter_only_generate_cfg_when_we_have_a_rule_which_depends_on_it
Closed

perf(linter): only generate cfg when we have a rule which depends on it.#3745
rzvxa wants to merge 2 commits into06-18-feat_linter_add_use_cfg_attributefrom
06-18-perf_linter_only_generate_cfg_when_we_have_a_rule_which_depends_on_it

Conversation

@rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Jun 18, 2024

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 18, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

rzvxa commented Jun 18, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-linter Area - Linter label Jun 18, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 18, 2024

CodSpeed Performance Report

Merging #3745 will improve performances by 3.54%

Comparing 06-18-perf_linter_only_generate_cfg_when_we_have_a_rule_which_depends_on_it (7ac80eb) with 06-18-feat_linter_add_use_cfg_attribute (6198181)

Summary

⚡ 1 improvements
✅ 21 untouched benchmarks

Benchmarks breakdown

Benchmark 06-18-feat_linter_add_use_cfg_attribute 06-18-perf_linter_only_generate_cfg_when_we_have_a_rule_which_depends_on_it Change
codegen_sourcemap[react.development.js] 2.1 ms 2 ms +3.54%

@rzvxa rzvxa force-pushed the 06-18-feat_linter_add_use_cfg_attribute branch from a343b03 to ebc729b Compare June 18, 2024 19:54
@rzvxa rzvxa force-pushed the 06-18-perf_linter_only_generate_cfg_when_we_have_a_rule_which_depends_on_it branch from b077686 to 355fd10 Compare June 18, 2024 19:54
@rzvxa rzvxa force-pushed the 06-18-perf_linter_only_generate_cfg_when_we_have_a_rule_which_depends_on_it branch from 355fd10 to 400cbd1 Compare June 18, 2024 19:55
@rzvxa rzvxa marked this pull request as ready for review June 18, 2024 20:06
@Boshen Boshen force-pushed the 06-18-feat_linter_add_use_cfg_attribute branch from a533fde to 6198181 Compare June 19, 2024 05:17
@Boshen Boshen force-pushed the 06-18-perf_linter_only_generate_cfg_when_we_have_a_rule_which_depends_on_it branch from be0dd5b to 7ac80eb Compare June 19, 2024 05:17
@Boshen Boshen closed this Jun 19, 2024
@Boshen Boshen deleted the 06-18-perf_linter_only_generate_cfg_when_we_have_a_rule_which_depends_on_it branch June 27, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants