refactor(transform): transformer use Traverse#3182
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
CodSpeed Performance ReportMerging #3182 will degrade performances by 3.69%Comparing Summary
Benchmarks breakdown
|
This was referenced May 6, 2024
Dunqing
approved these changes
May 8, 2024
Member
Author
|
We discussed and agreed to merge as is without scopes support, and to add that later on in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Sliced off from #3152.
This switches the transformer over to use
Traverseinstead ofVisitMut.This is incomplete - scopes are not implemented yet. At present, no transforms use scopes anyway, so all tests pass, but regardless I don't think should be merged until the implementation is complete.