Skip to content

feat(transformer): implement plugin-transform-react-display-name top-down#2937

Merged
Boshen merged 2 commits intomainfrom
react-display-name
Apr 11, 2024
Merged

feat(transformer): implement plugin-transform-react-display-name top-down#2937
Boshen merged 2 commits intomainfrom
react-display-name

Conversation

@Boshen Boshen requested review from milesj and rzvxa April 11, 2024 06:14
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Apr 11, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 11, 2024

CodSpeed Performance Report

Merging #2937 will improve performances by 6.54%

Comparing react-display-name (85c7b20) with main (07bd85e)

Summary

⚡ 1 improvements
✅ 30 untouched benchmarks

Benchmarks breakdown

Benchmark main react-display-name Change
sourcemap[react.development.js] 21 ms 19.7 ms +6.54%

@Boshen
Copy link
Member Author

Boshen commented Apr 11, 2024

I'm going to merge this and moving onto finding the next challenge for y'all.

@Boshen Boshen merged commit 02adc76 into main Apr 11, 2024
@Boshen Boshen deleted the react-display-name branch April 11, 2024 07:32
Dunqing pushed a commit that referenced this pull request May 8, 2024
…up lookup (#3183)

Sliced off from #3152.

Re-implement `transform-react-display-name` using bottom-up lookup
provided by `Traverse` trait.

This fixes the 1 remaining failing test case for this plugin (see
#2937).

`Traverse` is not complete yet (see #3182), so this is also not ready to
merge yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant