perf(linter/no-const-assign): use BindingPattern::get_symbol_ids

[camc314]

this should be faster as it avoids a deref to get the symbol id

[camc314]

• perf(linter/no-const-assign): use BindingPattern::get_symbol_ids #20533 👈 (View in Graphite)
• feat(ast): add method to retrieve SymbolIds from BindingPattern #20532
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

Optimizes the eslint/no-const-assign linter rule’s handling of const/using variable declarators by iterating symbol IDs directly from the binding pattern.

Changes:

• Replace get_binding_identifiers() + ident.symbol_id() with BindingPattern::get_symbol_ids() in NoConstAssign::run.

[codspeed-hq]

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 52 skipped benchmarks¹

---

_{Comparing c/03-19-perf_linter_no-const-assign_use_bindingpattern_get_symbol_ids_ (9ddfb42) with c/03-19-feat_ast_add_method_to_retrieve_symbolid_s_from_bindingpattern (76cd0b1)}

Footnotes

1. 52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[graphite-app]

Merge activity

• Mar 19, 9:29 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Mar 19, 9:42 PM UTC: Merged by the Graphite merge queue.