Skip to content

feat(ast): add method to retrieve SymbolIds from BindingPattern#20532

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/03-19-feat_ast_add_method_to_retrieve_symbolid_s_from_bindingpattern
Mar 19, 2026
Merged

feat(ast): add method to retrieve SymbolIds from BindingPattern#20532
graphite-app[bot] merged 1 commit intomainfrom
c/03-19-feat_ast_add_method_to_retrieve_symbolid_s_from_bindingpattern

Conversation

@camc314
Copy link
Copy Markdown
Contributor

@camc314 camc314 commented Mar 19, 2026

No description provided.

@camc314 camc314 marked this pull request as ready for review March 19, 2026 21:06
Copilot AI review requested due to automatic review settings March 19, 2026 21:06
Copy link
Copy Markdown
Contributor Author

camc314 commented Mar 19, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new BindingPattern helper for extracting semantic SymbolIds from all bound identifiers within a binding pattern, intended to simplify downstream consumers that currently walk binding identifiers and read symbol_id.

Changes:

  • Import SymbolId into crates/oxc_ast/src/ast_impl/js.rs.
  • Add recursive traversal (append_symbol_ids) over BindingPattern variants to collect symbol IDs.
  • Expose BindingPattern::get_symbol_ids() as a public API returning an iterator of collected SymbolIds.

@camc314 camc314 force-pushed the c/03-19-feat_ast_add_method_to_retrieve_symbolid_s_from_bindingpattern branch 2 times, most recently from 4781da9 to 494f267 Compare March 19, 2026 21:12
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 19, 2026

Merging this PR will not alter performance

✅ 53 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing c/03-19-feat_ast_add_method_to_retrieve_symbolid_s_from_bindingpattern (76cd0b1) with main (6cd513f)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (6528f37) during the generation of this report, so 6cd513f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Mar 19, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the c/03-19-feat_ast_add_method_to_retrieve_symbolid_s_from_bindingpattern branch from 494f267 to 76cd0b1 Compare March 19, 2026 21:29
@graphite-app graphite-app bot merged commit 76cd0b1 into main Mar 19, 2026
30 checks passed
@graphite-app graphite-app bot deleted the c/03-19-feat_ast_add_method_to_retrieve_symbolid_s_from_bindingpattern branch March 19, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants