Skip to content

feat(linter/array-callback-return): use CFG for analysis #20498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Mar 19, 2026
+119 −421
Merged

feat(linter/array-callback-return): use CFG for analysis #20498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/oxc_linter/src/rules/eslint/array_callback_return/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ impl Rule for ArrayCallbackReturn {
let return_status = if always_explicit_return {
StatementReturnStatus::AlwaysExplicit
} else {
check_function_body(function_body)
check_function_body(node.id(), ctx.semantic())
};

match (array_method, self.check_for_each, self.allow_void, self.allow_implicit) {
Expand Down Expand Up @@ -665,6 +665,7 @@ const _test = fruits.map((fruit) => {
("foo.every(() => {})", None),
("foo.every(function() { if (a) return true; })", None),
("foo.every(function cb() { if (a) return true; })", None),
("foo.map(() => { while (true) { if (a) break; return 1; } })", None),
("foo.every(function() { switch (a) { case 0: break; default: return true; } })", None),
("foo.every(function foo() { switch (a) { case 0: break; default: return true; } })", None),
("foo.every(function() { try { bar(); } catch (err) { return true; } })", None),
Expand Down
Loading
Loading