feat(linter/array-callback-return): use CFG for analysis

[camc314]

No description provided.

[camc314]

• feat(linter/array-callback-return): use CFG for analysis #20498 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This PR updates the eslint(array-callback-return) rule to determine whether callbacks return on all paths using the repository’s Control Flow Graph (CFG) rather than the prior AST-local return analysis.

Changes:

• Switch array-callback-return’s return-path detection to a CFG-based analysis (check_function_body(node.id(), ctx.semantic())).
• Adjust return-span collection for allowVoid handling to better match intended diagnostics.
• Update rule tests/snapshots and add a new failing case covering a while(true) loop with a break path.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
crates/oxc_linter/src/rules/eslint/array_callback_return/return_checker.rs	Replaces function-body return checking with CFG traversal logic; refactors return span handling; removes AST-analysis unit tests.
crates/oxc_linter/src/rules/eslint/array_callback_return/mod.rs	Wires the rule to the new CFG-based checker and adds a regression test case.
crates/oxc_linter/src/snapshots/eslint_array_callback_return.snap	Updates snapshot output to include the newly-detected missing-return scenario.

---

You can also share your feedback on Copilot code review. Take the survey.

[codspeed-hq]

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 52 skipped benchmarks¹

---

_{Comparing c/03-18-feat_linter_array-callback-return_use_cfg_for_analysis (e990b14) with main (65a7c3c)}

Footnotes

1. 52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[camc314]

Merge activity

• Mar 19, 10:31 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Mar 19, 10:31 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Mar 19, 10:38 PM UTC: Merged by the Graphite merge queue.